LGTM (if all comments are addressed).
https://codereview.chromium.org/620553008/diff/20001/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/620553008/diff/20001/src/compiler/simplified-lowering.cc#newcode355
src/compiler/simplified-lowering.cc:355: bool CanBeInt32Binop(Node*
node, MachineTypeUnion use) {
Please address my previous comment about the "CanBe" prefix. As
discussed offline, I would be fine with "CanLowerTo" instead.
https://codereview.chromium.org/620553008/diff/20001/test/cctest/compiler/test-simplified-lowering.cc
File test/cctest/compiler/test-simplified-lowering.cc (right):
https://codereview.chromium.org/620553008/diff/20001/test/cctest/compiler/test-simplified-lowering.cc#newcode62
test/cctest/compiler/test-simplified-lowering.cc:62: FILE* dot_file =
fopen("/tmp/test-lowered.dot", "w+");
Looks like a left-over, let's drop it again.
https://codereview.chromium.org/620553008/diff/20001/test/mjsunit/asm/int32_div.js
File test/mjsunit/asm/int32_div.js (right):
https://codereview.chromium.org/620553008/diff/20001/test/mjsunit/asm/int32_div.js#newcode1
test/mjsunit/asm/int32_div.js:1: // Copyright 2014 the V8 project
authors. All rights reserved.
Can we rename this file (and friends) to use dashes instead of
underscores to be consistent with the rest of the code-base?
https://codereview.chromium.org/620553008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
