https://codereview.chromium.org/629903003/diff/60001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/629903003/diff/60001/src/heap/gc-idle-time-handler.h#newcode158
src/heap/gc-idle-time-handler.h:158: static bool DoMarkCompact(size_t
idle_time_in_ms, size_t size_of_objects,
On 2014/10/06 14:56:47, Erik Corry Chromium.org wrote:
I would prefer "ShouldDoMarkCompact" to make it clearer that this
checks whether
we should do a mark-compact GC, rather than actually doing it.
Done.
https://codereview.chromium.org/629903003/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/629903003/diff/60001/src/heap/heap.cc#newcode4348
src/heap/heap.cc:4348: true, false);
On 2014/10/06 12:36:01, ulan wrote:
enum instead of bool would be more readable here.
Done.
https://codereview.chromium.org/629903003/diff/60001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/629903003/diff/60001/src/heap/incremental-marking.cc#newcode947
src/heap/incremental-marking.cc:947: IncrementIdleMarkingDelayCounter();
On 2014/10/06 14:56:47, Erik Corry Chromium.org wrote:
If we increment this every time we do a step, then I think it will
always be
above 3 when we check it. What am I missing?
Uff, good catch. We should just increment the counter when we finish
marking but do not complete. Done.
https://codereview.chromium.org/629903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
