lgtm
https://codereview.chromium.org/629903003/diff/100001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/629903003/diff/100001/test/cctest/test-heap.cc#newcode2201
test/cctest/test-heap.cc:2201: marking->Step(100 * MB,
IncrementalMarking::NO_GC_VIA_STACK_GUARD,
"100 * MB" looks fragile, but I guess it is sufficient. One possible
solution would be to make Step() return number of marked bytes and do
"while (Step() > 0)";
https://codereview.chromium.org/629903003/diff/100001/test/cctest/test-heap.cc#newcode2220
test/cctest/test-heap.cc:2220: CHECK_EQ(CcTest::heap()->gc_count(),
kShortIdleTimeInMs);
Did you mean CHECK_EQ(CcTest::heap()->gc_count(), 1) ?
https://codereview.chromium.org/629903003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
