LGTM but I would want Igor to verify that the codegen is good too.
https://codereview.chromium.org/638623002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/638623002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode4419
src/ia32/full-codegen-ia32.cc:4419: if (assign_type == NAMED_PROPERTY) {
maybe switch here?
https://codereview.chromium.org/638623002/diff/20001/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/638623002/diff/20001/src/runtime/runtime-classes.cc#newcode164
src/runtime/runtime-classes.cc:164: return
ThrowUnsupportedSuper(isolate);
// TODO(dslomov): Implement
https://codereview.chromium.org/638623002/diff/20001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/638623002/diff/20001/src/runtime/runtime.h#newcode196
src/runtime/runtime.h:196: F(StoreKeyedToSuper_Strict, 4, 1)
\
Same comment here as I commented on for StoreToSuper. Can we make this
one runtime function that takes a Smi for StrictMode? Maybe there is a
reason to prefer two runtime functions here and if so I would like to
know what it is.
https://codereview.chromium.org/638623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
