LGTM.
Nit: inconsistent use of uppercase/lowercase for hex digits (e.g. `\u180e`
vs.
`0x180E` in the same file).
https://codereview.chromium.org/638643002/diff/40001/test/mjsunit/var.js
File test/mjsunit/var.js (right):
https://codereview.chromium.org/638643002/diff/40001/test/mjsunit/var.js#newcode40
test/mjsunit/var.js:40: assertThrows("var \\u2E2F;", SyntaxError);
Maybe add the tests from https://codereview.chromium.org/638643002/#msg3
here as well, just in case? Or do you think it's enough to have them in
`unicode-predicates-unittest.cc` only?
https://codereview.chromium.org/638643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
