Reviewers: Igor Sheludko,
Description:
Resolve race between starting the profiler thread and the logging timer
BUG=none
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/638943002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/log.cc
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index
db1f3cf880e63f7a4794c39618770f81ea3b22cb..265895aeef7a5f6420a2c5b883b5868b17a26e7f
100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1866,14 +1866,14 @@ bool Logger::SetUp(Isolate* isolate) {
is_logging_ = true;
}
+ if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();
+
if (FLAG_prof) {
profiler_ = new Profiler(isolate);
is_logging_ = true;
profiler_->Engage();
}
- if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start();
-
return true;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
