On 2014/10/09 11:55:51, Yang wrote:
On 2014/10/09 11:54:51, Yang wrote:
> On 2014/10/09 11:53:57, mathias wrote:
> > On 2014/10/09 10:40:16, mathias wrote:
> > > How about adding some tests to test/mjsunit/var.js? E.g.
> > >
> > > assertDoesNotThrow("var 𐐼;"); // U+1043C DESERET SMALL LETTER DEE)
> >
> > Not sure if this is relevant at all, but `uchar.h` still mentions Unicode
> 3.0.0
> > rather than 7.0.0. Search for “(The Unicode Standard, Version 3.0, chapter
> 5.16
> > Identifiers).”.
> >
> > Could that be why the above test fails at the moment?
>
> The reason it's failing is because the parser is still using UTF16 for
> everything. I'll have to fix that first.

btw my uchar.h says

#define U_UNICODE_VERSION "6.3"

Ah. I see what you mean with Unicode Standard Version 3.0. It defines ID_Start as categories Lu, Ll, Lt, Lm, Lo, Nl. This doesn't include Other_ID_Start and doesn't exclude properties Pattern_*. But that's fine, since those differences
are only in the BMP. We only resort to ICU for code points in SMPs.

https://codereview.chromium.org/640193002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to