On 2014/10/09 12:21:29, Yang wrote:
On 2014/10/09 12:03:02, mathias wrote:
> On 2014/10/09 11:55:51, Yang wrote:
> > On 2014/10/09 11:54:51, Yang wrote:
> > > On 2014/10/09 11:53:57, mathias wrote:
> > > > On 2014/10/09 10:40:16, mathias wrote:
> > > > > How about adding some tests to test/mjsunit/var.js? E.g.
> > > > >
> > > > > assertDoesNotThrow("var 𐐼;"); // U+1043C DESERET SMALL LETTER
DEE)
> > > >
> > > > Not sure if this is relevant at all, but `uchar.h` still mentions
Unicode
> > > 3.0.0
> > > > rather than 7.0.0. Search for β€œ(The Unicode Standard, Version 3.0,
chapter
> > > 5.16
> > > > Identifiers).”.
> > > >
> > > > Could that be why the above test fails at the moment?
> > >
> > > The reason it's failing is because the parser is still using UTF16 for
> > > everything. I'll have to fix that first.
> >
> > btw my uchar.h says
> >
> > #define U_UNICODE_VERSION "6.3"
>
> I was looking at line 2972 β€” just a comment, but it’s kinda confusing. I
thought
> we were using Unicode 7.0.0 now?

The tables in src/unicode.cc are 7.0.0, but ICU hasn't caught up yet. We use
ICU
for locales, and in this case, SMP.

Uploaded the fix for the parser.

https://codereview.chromium.org/640193002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to