Reviewers: Søren Gjesse, Description: Reverting 2909,2908.
Please review this at http://codereview.chromium.org/215007 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/builtins-ia32.cc Index: src/ia32/builtins-ia32.cc =================================================================== --- src/ia32/builtins-ia32.cc (revision 2909) +++ src/ia32/builtins-ia32.cc (working copy) @@ -740,10 +740,7 @@ __ mov(FieldOperand(scratch1, Array::kLengthOffset), Immediate(holes)); // Fill the FixedArray with the hole value. Inline the code if short. - // Reconsider loop unfolding if kPreallocatedArrayElements gets changed. - static const int kLoopUnfoldLimit = 4; - ASSERT(kPreallocatedArrayElements <= kLoopUnfoldLimit); - if (holes <= kLoopUnfoldLimit) { + if (holes <= 4) { // Use a scratch register here to have only one reloc info when unfolding // the loop. __ mov(scratch3, Factory::the_hole_value()); @@ -1071,7 +1068,7 @@ __ Assert(equal, "Unexpected initial map for Array function"); } - // Run the native code for the Array function called as a normal function. + // Run the native code for the Array function called as constructor. ArrayNativeCode(masm, false, &generic_array_code); // Jump to the generic array code in case the specialized code cannot handle @@ -1113,6 +1110,7 @@ // Jump to the generic construct code in case the specialized code cannot // handle the construction. __ bind(&generic_constructor); + GenerateLoadArrayFunction(masm, edi); Code* code = Builtins::builtin(Builtins::JSConstructStubGeneric); Handle<Code> generic_construct_stub(code); __ jmp(generic_construct_stub, RelocInfo::CODE_TARGET); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
