LGTM, nice catch on the uninitialized kDoubleRegZero in the cctests.
https://codereview.chromium.org/646923003/diff/1/src/compiler/mips/code-generator-mips.cc
File src/compiler/mips/code-generator-mips.cc (right):
https://codereview.chromium.org/646923003/diff/1/src/compiler/mips/code-generator-mips.cc#newcode834
src/compiler/mips/code-generator-mips.cc:834: __ Move(dst,
src.ToFloat64(), true);
nit: the bool at the call site here is a bit confusing to the reader,
you might consider making an enum value for this to enhance readability.
Though naming of this "force_load" functionality is not going to be very
meaningful in this context any way, so this can be optional. Let's have
a brief side discussion about this.
https://codereview.chromium.org/646923003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
