LGTM, once you fix the naming convention issue.
https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):
https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assembler-mips.h#newcode1668
src/mips/macro-assembler-mips.h:1668: bool has_double_zero_reg_set;
You need a trailing underscore on this var: has_double_zero_reg_set_;
https://codereview.chromium.org/646923003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
