Comments addressed, PTAL
https://codereview.chromium.org/649603003/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/649603003/diff/160001/src/objects.cc#newcode856
src/objects.cc:856: if (js_object->HasIndexedInterceptor()) {
On 2014/10/13 12:16:36, Toon Verwaest wrote:
If the holder is not the receiver, query the attributes rather than
using the
presence of the setter.
If there's no setter, at least named properties can have data
properties behind
the interceptor.
Done.
https://codereview.chromium.org/649603003/diff/160001/src/objects.cc#newcode884
src/objects.cc:884: return WriteToReadOnlyElement(isolate, receiver,
index, value, strict_mode);
On 2014/10/13 12:16:36, Toon Verwaest wrote:
You only need to throw read-only exceptions for indices within range
of string
receivers. In all other cases, the operation is swallowed as the
receiver is
wrapped (ToObject).
Done.
https://codereview.chromium.org/649603003/diff/160001/src/objects.cc#newcode894
src/objects.cc:894: false);
On 2014/10/13 12:16:36, Toon Verwaest wrote:
Add a test to ensure that SetElement updates the length if the
receiver is an
array.
Done.
https://codereview.chromium.org/649603003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
