https://codereview.chromium.org/649603003/diff/260001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/649603003/diff/260001/src/objects.cc#newcode807
src/objects.cc:807: uint32_t index) {
On 2014/10/14 08:31:54, Toon Verwaest wrote:
Replace by JSObject::GetOwnElementAccessorPair
Is that enough? SetElementWithCallback handles more cases than just
AccessorPair
https://codereview.chromium.org/649603003/diff/260001/src/objects.cc#newcode860
src/objects.cc:860: if (from_interceptor.has_value) {
On 2014/10/14 08:31:54, Toon Verwaest wrote:
The contract is normally that if !has_value, an exception was thrown.
Return
empty MaybeHandle<Object>() in that case. You probably also want done
=
from_interceptor.value != ABSENT;
I see. Wow, all those things could use some documenting :)
https://codereview.chromium.org/649603003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
