Reviewers: dcarney,
Description:
[x86] Several small performance improvements.
- Generate
cmp reg, 0
instead of
test reg, -1
for word tests.
- Generate
mov reg, [stack slot]
add reg, reg
jo label
instead of
mov reg, [stack slot]
add reg, [stack slot]
jo label
for SMI tagging.
- Improve materialization of int32 constants on X86-64.
- Branch fusion fix for Word64And and Int64Sub on X86-64.
[email protected]
Please review this at https://codereview.chromium.org/651383003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+33, -25 lines):
M src/compiler/ia32/instruction-selector-ia32.cc
M src/compiler/x64/code-generator-x64.cc
M src/compiler/x64/instruction-selector-x64.cc
Index: src/compiler/ia32/instruction-selector-ia32.cc
diff --git a/src/compiler/ia32/instruction-selector-ia32.cc
b/src/compiler/ia32/instruction-selector-ia32.cc
index
add0a3f2b1fc17f47ffc1926844fadaadedb303f..99685f14e58ff106ead5107fc1886f5f6e6b1cdf
100644
--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -259,7 +259,18 @@ static void VisitBinop(InstructionSelector* selector,
Node* node,
size_t output_count = 0;
// TODO(turbofan): match complex addressing modes.
- if (g.CanBeImmediate(right)) {
+ if (left == right) {
+ // If both inputs refer to the same operand, enforce allocating a
register
+ // for both of them to ensure that we don't end up generating code like
+ // this:
+ //
+ // mov eax, [ebp-0x10]
+ // add eax, [ebp-0x10]
+ // jo label
+ InstructionOperand* const input = g.UseRegister(left);
+ inputs[input_count++] = input;
+ inputs[input_count++] = input;
+ } else if (g.CanBeImmediate(right)) {
inputs[input_count++] = g.UseRegister(left);
inputs[input_count++] = g.UseImmediate(right);
} else {
@@ -674,13 +685,6 @@ static inline void
VisitWordCompare(InstructionSelector* selector, Node* node,
}
-static void VisitWordTest(InstructionSelector* selector, Node* node,
- FlagsContinuation* cont) {
- IA32OperandGenerator g(selector);
- VisitCompare(selector, kIA32Test, g.Use(node), g.TempImmediate(-1),
cont);
-}
-
-
// Shared routine for multiple float compare operations.
static void VisitFloat64Compare(InstructionSelector* selector, Node* node,
FlagsContinuation* cont) {
@@ -694,7 +698,7 @@ static void VisitFloat64Compare(InstructionSelector*
selector, Node* node,
void InstructionSelector::VisitBranch(Node* branch, BasicBlock* tbranch,
BasicBlock* fbranch) {
- OperandGenerator g(this);
+ IA32OperandGenerator g(this);
Node* user = branch;
Node* value = branch->InputAt(0);
@@ -780,7 +784,7 @@ void InstructionSelector::VisitBranch(Node* branch,
BasicBlock* tbranch,
}
// Branch could not be combined with a compare, emit compare against 0.
- VisitWordTest(this, value, &cont);
+ VisitCompare(this, kIA32Cmp, g.Use(value), g.TempImmediate(0), &cont);
}
@@ -799,7 +803,6 @@ void InstructionSelector::VisitWord32Equal(Node* const
node) {
default:
break;
}
- return VisitWordTest(this, value, &cont);
}
}
return VisitWordCompare(this, node, kIA32Cmp, &cont, false);
Index: src/compiler/x64/code-generator-x64.cc
diff --git a/src/compiler/x64/code-generator-x64.cc
b/src/compiler/x64/code-generator-x64.cc
index
361862cef38095063e143f3e0ca104ade0406b00..accbda37597dc8fbfe238f175ba36a54f36dfbda
100644
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -869,8 +869,7 @@ void CodeGenerator::AssembleMove(InstructionOperand*
source,
: kScratchRegister;
switch (src.type()) {
case Constant::kInt32:
- // TODO(dcarney): don't need scratch in this case.
- __ movq(dst, Immediate(src.ToInt32()));
+ __ Set(dst, src.ToInt32());
break;
case Constant::kInt64:
__ Set(dst, src.ToInt64());
Index: src/compiler/x64/instruction-selector-x64.cc
diff --git a/src/compiler/x64/instruction-selector-x64.cc
b/src/compiler/x64/instruction-selector-x64.cc
index
d102e847181f3c8deec72497659bc9d5adf407bd..c84edfe839005d671e5f88700ed74de20f1d75a4
100644
--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -240,7 +240,18 @@ static void VisitBinop(InstructionSelector* selector,
Node* node,
size_t output_count = 0;
// TODO(turbofan): match complex addressing modes.
- if (g.CanBeImmediate(right)) {
+ if (left == right) {
+ // If both inputs refer to the same operand, enforce allocating a
register
+ // for both of them to ensure that we don't end up generating code like
+ // this:
+ //
+ // mov rax, [rbp-0x10]
+ // add rax, [rbp-0x10]
+ // jo label
+ InstructionOperand* const input = g.UseRegister(left);
+ inputs[input_count++] = input;
+ inputs[input_count++] = input;
+ } else if (g.CanBeImmediate(right)) {
inputs[input_count++] = g.UseRegister(left);
inputs[input_count++] = g.UseImmediate(right);
} else {
@@ -796,13 +807,6 @@ static void VisitWordCompare(InstructionSelector*
selector, Node* node,
}
-static void VisitWordTest(InstructionSelector* selector, Node* node,
- InstructionCode opcode, FlagsContinuation* cont)
{
- X64OperandGenerator g(selector);
- VisitCompare(selector, opcode, g.Use(node), g.TempImmediate(-1), cont);
-}
-
-
static void VisitFloat64Compare(InstructionSelector* selector, Node* node,
FlagsContinuation* cont) {
X64OperandGenerator g(selector);
@@ -815,7 +819,7 @@ static void VisitFloat64Compare(InstructionSelector*
selector, Node* node,
void InstructionSelector::VisitBranch(Node* branch, BasicBlock* tbranch,
BasicBlock* fbranch) {
- OperandGenerator g(this);
+ X64OperandGenerator g(this);
Node* user = branch;
Node* value = branch->InputAt(0);
@@ -918,15 +922,19 @@ void InstructionSelector::VisitBranch(Node* branch,
BasicBlock* tbranch,
break;
case IrOpcode::kInt32Sub:
return VisitWordCompare(this, value, kX64Cmp32, &cont, false);
+ case IrOpcode::kInt64Sub:
+ return VisitWordCompare(this, value, kX64Cmp, &cont, false);
case IrOpcode::kWord32And:
return VisitWordCompare(this, value, kX64Test32, &cont, true);
+ case IrOpcode::kWord64And:
+ return VisitWordCompare(this, value, kX64Test, &cont, true);
default:
break;
}
}
// Branch could not be combined with a compare, emit compare against 0.
- VisitWordTest(this, value, kX64Test32, &cont);
+ VisitCompare(this, kX64Cmp32, g.Use(value), g.TempImmediate(0), &cont);
}
@@ -945,7 +953,6 @@ void InstructionSelector::VisitWord32Equal(Node* const
node) {
default:
break;
}
- return VisitWordTest(this, value, kX64Test32, &cont);
}
}
VisitWordCompare(this, node, kX64Cmp32, &cont, false);
@@ -991,7 +998,6 @@ void InstructionSelector::VisitWord64Equal(Node* const
node) {
default:
break;
}
- return VisitWordTest(this, value, kX64Test, &cont);
}
}
VisitWordCompare(this, node, kX64Cmp, &cont, false);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
