Adressed your comments.
https://codereview.chromium.org/612043003/diff/80002/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/612043003/diff/80002/src/compiler/js-inlining.cc#newcode485
src/compiler/js-inlining.cc:485: f->function_id !=
Runtime::kInlineValueOf) {
On 2014/10/15 08:44:58, Michael Starzinger wrote:
This only white-lists %_ValueOf to be inline-able. Is that
intentional? If we
want to land it like this, then we should at least leave a fat TODO
here.
Leftover, cleaned it up.
https://codereview.chromium.org/612043003/diff/80002/src/compiler/js-intrinsic-builder.h
File src/compiler/js-intrinsic-builder.h (right):
https://codereview.chromium.org/612043003/diff/80002/src/compiler/js-intrinsic-builder.h#newcode19
src/compiler/js-intrinsic-builder.h:19: std::pair<Node*, Node*>
BuildGraphFor(Runtime::FunctionId id,
On 2014/10/15 08:44:59, Michael Starzinger wrote:
Can we add a typedef for this pair?
Done.
https://codereview.chromium.org/612043003/diff/80002/src/compiler/js-intrinsic-builder.h#newcode22
src/compiler/js-intrinsic-builder.h:22: std::pair<Node*, Node*>
BuildGraphFor_IsSmi(const NodeVector& arguments);
On 2014/10/15 08:44:59, Michael Starzinger wrote:
Can we make the dispatched methods private and only have one
entry-point in this
builder for now?
Done.
https://codereview.chromium.org/612043003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
