LGTM (with one last comment).
https://codereview.chromium.org/612043003/diff/330001/src/compiler/simplified-operator.h
File src/compiler/simplified-operator.h (right):
https://codereview.chromium.org/612043003/diff/330001/src/compiler/simplified-operator.h#newcode158
src/compiler/simplified-operator.h:158: const Operator* IsSmi();
nit: Benedikt suggested to call these operators "ObjectIsSmi" and
"ObjectIsNonNegativeSmi" instead. I agree, this makes it clear what the
input type is. Also we should move them up a few lines to the other pure
operators (i.e. to line 139).
https://codereview.chromium.org/612043003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
