LGTM
https://codereview.chromium.org/661433002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/661433002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1
src/ia32/full-codegen-ia32.cc:1: / Copyright 2012 the V8 project
authors. All rights reserved.
oops
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js#newcode1254
test/mjsunit/harmony/super.js:1254: super();
Just to be clear that I understand this. This one calls?
ImplicitSubclassOfObject.__proto__.call(ImplicitSubclassOfObject);
which happens to be
Function.prototype.call(ImplicitSubclassOfObject);
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js#newcode1269
test/mjsunit/harmony/super.js:1269: // we throw TypeError.
Completely agree. I was reading up on the changes to the spec in
preparation for this CL and it should obviously by TypeError.
https://codereview.chromium.org/661433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
