Erik, thanks for review! CL updated.
Toon/Igor, could you take a look at the codegen as well?
https://codereview.chromium.org/661433002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/661433002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1
src/ia32/full-codegen-ia32.cc:1: / Copyright 2012 the V8 project
authors. All rights reserved.
On 2014/10/15 14:47:18, arv wrote:
oops
Done.
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js#newcode1254
test/mjsunit/harmony/super.js:1254: super();
On 2014/10/15 14:47:18, arv wrote:
Just to be clear that I understand this. This one calls?
ImplicitSubclassOfObject.__proto__.call(ImplicitSubclassOfObject);
which happens to be
Function.prototype.call(ImplicitSubclassOfObject);
You are right, this has to be called ImplicitSubclassOfFunction.
Renamed.
https://codereview.chromium.org/661433002/diff/20001/test/mjsunit/harmony/super.js#newcode1272
test/mjsunit/harmony/super.js:1272: }());
On 2014/10/15 14:49:54, arv wrote:
maybe add a test that mutates __proto__ and then uses the new proto?
var calls = 0;
function G() {
calls++;
}
function F() {}
super();
}
F.__proto__ = G;
new F();
assertEquals(1, calls);
F.__proto__ = function() {};
new F();
assertEquals(1, calls);
Done.
https://codereview.chromium.org/661433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
