LGTM
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (right):
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc#newcode71
src/type-feedback-vector.cc:71: // Fall through...
Uhm, what? Either "break;" or "// Fall through.", but not both!
(I'd just use an if/else, but if you like your switch statement, you can
keep it.)
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc#newcode78
src/type-feedback-vector.cc:78: // Now clear vector-based ICs. They are
all CallICs.
Whoa. The comment in the header said "leaves vector ic slots alone".
Is there a DCHECK we could guard the "They're all CallICs" invariant
with?
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.h#newcode18
src/type-feedback-vector.h:18: // 0: first_ic_slot_index (-1 if no ic
slots present)
the "-1" part is outdated, right?
https://codereview.chromium.org/650073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
