Addressed comments. Thx again, submitting...
--Michael
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (right):
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc#newcode71
src/type-feedback-vector.cc:71: // Fall through...
On 2014/10/20 10:29:43, Jakob wrote:
Uhm, what? Either "break;" or "// Fall through.", but not both!
(I'd just use an if/else, but if you like your switch statement, you
can keep
it.)
You are right, it's unwieldy...changing to if()...
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.cc#newcode78
src/type-feedback-vector.cc:78: // Now clear vector-based ICs. They are
all CallICs.
On 2014/10/20 10:29:43, Jakob wrote:
Whoa. The comment in the header said "leaves vector ic slots alone".
Is there a DCHECK we could guard the "They're all CallICs" invariant
with?
Nice catch, I'll fix that outdated comment in the header...it's an
artifact of the first try at this, where vector IC clearing was done
during RelocInfo marking.
Hmm, the DCHECK won't work because there isn't currently a "metadata"
section in the TypeFeedbackVector that can be checked to verify that
each IC slot is a CallIC. But my *next* CL already has such a structure,
and it's usage will be checked. The loop below will end up casing the
handling of each IC slot on something like
Code::KIND kind(FeedbackVectorICSlot slot);
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):
https://codereview.chromium.org/650073002/diff/580001/src/type-feedback-vector.h#newcode18
src/type-feedback-vector.h:18: // 0: first_ic_slot_index (-1 if no ic
slots present)
On 2014/10/20 10:29:43, Jakob wrote:
the "-1" part is outdated, right?
Indeed, thanks!
https://codereview.chromium.org/650073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
