I'll make the change so it does not need to be cleared.


https://codereview.chromium.org/649563006/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/649563006/diff/1/src/compiler.cc#newcode1286
src/compiler.cc:1286: // the inner function must be allowed to be
compiled lazily.
On 2014/10/20 13:51:14, jochen wrote:
nit. not related to this cl

Does this mean you would rather leave the spelling error in?

https://codereview.chromium.org/649563006/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/649563006/diff/1/src/globals.h#newcode294
src/globals.h:294: const uint64_t kPhantomReferenceZap = 0xca11bac;
On 2014/10/20 13:51:14, jochen wrote:
should there be a 32bit and a 64bit zap value?

I think 32 bit is enough - it's converted to a Smi.

https://codereview.chromium.org/649563006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to