https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/649563006/diff/20001/src/global-handles.cc#newcode256
src/global-handles.cc:256: DCHECK(*handle ==
Smi::FromInt(kPhantomReferenceZap));
On 2014/10/20 at 14:25:32, Erik Corry wrote:
On 2014/10/20 14:11:46, jochen wrote:
> should we set handle to a null-handle here?
I think that's not so useful. The callback then doesn't have an
indication of which handle is being cleared. By just zapping the
contents, the callback still has the location to key on if it has a hash
map or similar. This is the value the callback gets by doing operator*
on the handle.
There is the parameter, but often that is used to identify the
per-isolate object that holds state, not the individual reference that
is dying. We could add a second parameter, but that seems
over-engineered somehow.
but the address of the handle is completely new, it's allocated in the
handle scope two lines above. it's a fresh address, and it points to
garbage.
the embedder will have to put all infos in the params anyways
https://codereview.chromium.org/649563006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
