Adressed changes. Please take a look again.
https://codereview.chromium.org/668173002/diff/40001/src/compiler/machine-operator.h
File src/compiler/machine-operator.h (right):
https://codereview.chromium.org/668173002/diff/40001/src/compiler/machine-operator.h#newcode57
src/compiler/machine-operator.h:57: kRoundDown,
On 2014/10/22 14:05:42, titzer wrote:
A little confusing here.
These rounding modes map to operators, correct? Then why do we need
the separate
enum if it is not a parameter to the operator?
I thought it was cleaner to have one op + rounding mode instead of
several ops here. Changed it in the last upload. Please tell me which
you think is better.
https://codereview.chromium.org/668173002/diff/40001/src/compiler/machine-operator.h#newcode63
src/compiler/machine-operator.h:63: #define BACKEND_SPECIFIC_OPS(V) \
On 2014/10/22 14:05:42, titzer wrote:
Can we try to avoid the higher order macro stuff here? It's really
hard to tell
what methods are available on the MachineOperatorBuilder like this.
Done.
https://codereview.chromium.org/668173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
