Thanks for the comments so far! PTAL again :)
https://codereview.chromium.org/668173002/diff/60001/src/compiler/instruction-selector.h
File src/compiler/instruction-selector.h (right):
https://codereview.chromium.org/668173002/diff/60001/src/compiler/instruction-selector.h#newcode91
src/compiler/instruction-selector.h:91: static SupportedOperators
GetSupportedOperators();
On 2014/10/23 07:11:14, Benedikt Meurer wrote:
This should take a CpuFeatures parameter, because we certainly depend
on the CPU
features available.
As discussed, I'll add a todo.
https://codereview.chromium.org/668173002/diff/60001/src/compiler/machine-operator.h
File src/compiler/machine-operator.h (right):
https://codereview.chromium.org/668173002/diff/60001/src/compiler/machine-operator.h#newcode55
src/compiler/machine-operator.h:55: enum SupportedOperator {
On 2014/10/23 07:11:14, Benedikt Meurer wrote:
I'd not name it SupportedOperator, but rather move it to
MachineOperatorBuilder::Flags, because it's not only about the
availability of
operators but also about their behavior.
Done.
https://codereview.chromium.org/668173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
