https://codereview.chromium.org/657893003/diff/1/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/657893003/diff/1/src/ast-value-factory.h#newcode289
src/ast-value-factory.h:289: #define F(name, value) name##_ = NULL;
Nit: use same formatting as above.
https://codereview.chromium.org/657893003/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/657893003/diff/1/src/ast.h#newcode3404
src/ast.h:3404: const AstValue* value = b ?
ast_value_factory_->true_value()
Instead of making these changes here, can't we encapsulate the caching
by having the respective New operators just return the cached versions
internally?
https://codereview.chromium.org/657893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
