LGTM
https://codereview.chromium.org/657893003/diff/40001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/657893003/diff/40001/src/ast-value-factory.h#newcode323
src/ast-value-factory.h:323: #define F(name, function_name, type)
\
On 2014/10/24 10:08:19, marja wrote:
On 2014/10/23 13:21:29, rossberg wrote:
> Hm, this second-order macro magic still makes it rather hard to see
what's
being
> declared here. TBH, it seems overkill for a list of 3 functions that
is
unlikely
> to ever be extended.
>
> Can we have these functions declared explicitly, as before, and only
use a
> (first-order) macro for their implementation in the .cc file?
Tbh, I'm not sure what kind of macro you meant for generating the
implementation, but I took a guess - please have a look. It's
questionable
though whether that macro adds any value over writing the
implementations by
hand.
More or less what you had as F here (or similarly your
GENERATE_VALUE_GETTER now). I'm fine with reverting that bit of
macrofication, too, but I assumed you'd prefer to keep it. :)
https://codereview.chromium.org/657893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
