Some comments
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc#newcode70
src/runtime/runtime-function.cc:70: static String*
NameToFunctionName(Isolate* isolate, Name* name) {
This function shouldn't use naked pointers - use Handle<Name>,
Handle<String> etc. I'll guide you with comments below
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc#newcode71
src/runtime/runtime-function.cc:71: String* stringName = NULL;
Handle<String>
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc#newcode73
src/runtime/runtime-function.cc:73: // TODO(caitp): Follow proper rules
in section 9.2.11 (SetFunctionName)
Yes, fine to do in later CL - our names for getters and setters builtins
are wrong anyway.
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc#newcode75
src/runtime/runtime-function.cc:75: Object* symName =
Symbol::cast(name)->name();
Handle<Object> symName(Handle<Symbol>::cast(name)->name());
https://codereview.chromium.org/664333003/diff/20001/src/runtime/runtime-function.cc#newcode96
src/runtime/runtime-function.cc:96: CONVERT_ARG_CHECKED(Name, name, 1);
CONVERT_ARG_HANDLE_CHECKED
In line 92 above, s/SealHandleScope/HandleScope/
https://codereview.chromium.org/664333003/diff/20001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/664333003/diff/20001/src/typedarray.js#newcode304
src/typedarray.js:304: //TypedArrayGetToStringTag
Stray comment?
https://codereview.chromium.org/664333003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
