On 2014/10/24 15:11:19, caitp wrote:
On 2014/10/24 14:23:14, caitp wrote:
> On 2014/10/24 12:44:34, caitp wrote:
> > https://codereview.chromium.org/664333003/diff/40001/src/typedarray.js
> > File src/typedarray.js (right):
> >
> >
>
https://codereview.chromium.org/664333003/diff/40001/src/typedarray.js#newcode298
> > src/typedarray.js:298: return name;
> > admittedly the above if statement doesn't really make sense, it's just
> literally
> > following the spec --- fine to remove it
>
> hmmm this is broken in debug, looking...
ExtractAccessorPairProperty() would try to cast to a String() when calling
SetPropertyReference() --- but SetPropertyReference() actually takes a
Name,
which should work for Symbol getters/setters too. So it's a pretty trivial
change to fix those tests.
lgtm
https://codereview.chromium.org/664333003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
