Reviewers: loislo, Yang,
Message:
Now with fix for Mac.
Description:
Heap profiler clean-up: remove dead code
[email protected],[email protected]
LOG=N
BUG=Non
Please review this at https://codereview.chromium.org/681333003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -5 lines):
M src/heap-snapshot-generator.h
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
680e1cc4ad74b748aca7952dc30672973a2eae08..13f40db799be1f6332e412fbfc90ee5f77313156
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -2300,7 +2300,6 @@ NativeObjectsExplorer::NativeObjectsExplorer(
: isolate_(snapshot->profiler()->heap_object_map()->heap()->isolate()),
snapshot_(snapshot),
names_(snapshot_->profiler()->names()),
- progress_(progress),
embedder_queried_(false),
objects_by_info_(RetainedInfosMatch),
native_groups_(StringsMatch),
Index: src/heap-snapshot-generator.h
diff --git a/src/heap-snapshot-generator.h b/src/heap-snapshot-generator.h
index
3e4ce71b8ad80bb102092e7368e0380b0ffab577..646d497085d19c396d97544054d02371dc0af5bf
100644
--- a/src/heap-snapshot-generator.h
+++ b/src/heap-snapshot-generator.h
@@ -176,7 +176,6 @@ class HeapSnapshot {
void FillChildren();
void Print(int max_depth);
- void PrintEntriesSize();
private:
HeapEntry* AddRootEntry();
@@ -332,7 +331,6 @@ class V8HeapExplorer : public HeapEntriesAllocator {
v8::HeapProfiler::ObjectNameResolver* resolver);
virtual ~V8HeapExplorer();
virtual HeapEntry* AllocateEntry(HeapThing ptr);
- void AddRootEntries(SnapshotFiller* filler);
int EstimateObjectsCount(HeapIterator* iterator);
bool IterateAndExtractReferences(SnapshotFiller* filler);
void TagGlobalObjects();
@@ -473,7 +471,6 @@ class NativeObjectsExplorer {
NativeObjectsExplorer(HeapSnapshot* snapshot,
SnapshottingProgressReportingInterface* progress);
virtual ~NativeObjectsExplorer();
- void AddRootEntries(SnapshotFiller* filler);
int EstimateObjectsCount();
bool IterateAndExtractReferences(SnapshotFiller* filler);
@@ -506,7 +503,6 @@ class NativeObjectsExplorer {
Isolate* isolate_;
HeapSnapshot* snapshot_;
StringsStorage* names_;
- SnapshottingProgressReportingInterface* progress_;
bool embedder_queried_;
HeapObjectsSet in_groups_;
// RetainedObjectInfo* -> List<HeapObject*>*
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
