Reviewers: Igor Sheludko,
Message:
Hi Igor,
Here is 2nd try, thanks for the help! The only change is in
type-feedback-vector.h, the definition of class FeedbackNexus: I got rid of
the
union. PTAL,
thanks,
--Michael
Description:
Introduce FeedbackNexus for vector-based ics.
A FeedbackNexus is the combination of a feedback vector, a slot(s) in
the vector, along with methods to query and manipulate that information
in a type-correct way.
A CallIC will have a CallICNexus, a LoadIC a LoadICNexus, etc.,
reflecting the fact that different types of ICs configure their data
in unique ways.
This CL limits itself to introducing and using the nexus type only for
CallICs. A follow-up will use them for Load and KeyedLoadICs for the
case when the --vector-ics flag is turned on.
The notion of a Nexus is also embedded at the lowest level of the IC
class. This makes sense because more ICs should become vector-based
in the future.
[email protected]
Please review this at https://codereview.chromium.org/683933002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+416, -137 lines):
M src/ic/ic.h
M src/ic/ic.cc
M src/ic/ic-inl.h
M src/ic/ic-state.h
M src/ic/ic-state.cc
M src/type-feedback-vector.h
M src/type-feedback-vector.cc
M test/cctest/test-feedback-vector.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
