Reviewers: Yang,
Message:
PTAL at this one-liner. Should be the last place where we call
SetPropertyReference casting to String instead of Name.
Description:
Change cast to String to cast to Symbol in heap-snapshot-generator.
[email protected]
Please review this at https://codereview.chromium.org/684893002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
680e1cc4ad74b748aca7952dc30672973a2eae08..6fe050f22eceb52f6406304226a79f90025d192a
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -1698,7 +1698,7 @@ void
V8HeapExplorer::ExtractPropertyReferences(JSObject* js_obj, int entry) {
continue;
}
if (ExtractAccessorPairProperty(js_obj, entry, k, value)) continue;
- SetPropertyReference(js_obj, entry, String::cast(k), value);
+ SetPropertyReference(js_obj, entry, Name::cast(k), value);
}
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
