https://codereview.chromium.org/656123005/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/656123005/diff/1/src/compiler/ast-graph-builder.cc#newcode592
src/compiler/ast-graph-builder.cc:592: if (loop_assignment_analysis_ ==
NULL) return NULL;
On 2014/10/28 14:23:29, danno wrote:
This seems a bit weird. Why is it OK to call this at all when
loop_assignment_analysis_ == NULL?
It's so that there's one place where we make the decision about whether
to perform the analysis (i.e. in CreateGraph()), and later we just check
if there is an analysis result available.
https://codereview.chromium.org/656123005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
