LGTM when the Win64 issue is fixed.
https://codereview.chromium.org/683243005/diff/1/src/data-flow.cc
File src/data-flow.cc (right):
https://codereview.chromium.org/683243005/diff/1/src/data-flow.cc#newcode50
src/data-flow.cc:50: count += base::bits::CountPopulation64(data);
Not really related to your CL, but I think we should templatize the
Foo32/Foo64 stuff in base::bits.
The "data != 0" is a (premature?) optimization, so the body of the loop
should simply look like:
count += base::bits::CountPopulation(data_[i]);
https://codereview.chromium.org/683243005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
