FYI
https://codereview.chromium.org/693813002/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/693813002/diff/20001/src/factory.cc#newcode1725
src/factory.cc:1725: Handle<JSMapIterator> Factory::NewJSMapIterator() {
Maybe this should take the table, index and kind since without those the
iterator is not going to behave reasonable.
https://codereview.chromium.org/693813002/diff/20001/test/mjsunit/es6/mirror-iterators.js
File test/mjsunit/es6/mirror-iterators.js (right):
https://codereview.chromium.org/693813002/diff/20001/test/mjsunit/es6/mirror-iterators.js#newcode38
test/mjsunit/es6/mirror-iterators.js:38:
testIteratorMirror(set.entries(), [[41, 41], [42, 42], [o1, o1], [o2,
o2]]);
I think it would be good to have a test that creates a mirror after the
original iterator is halfway through.
https://codereview.chromium.org/693813002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
