LGTM
http://codereview.chromium.org/244022/diff/1001/2004 File src/spaces.cc (right): http://codereview.chromium.org/244022/diff/1001/2004#newcode170 Line 170: FreeBlock entire_range = {static_cast<Address>(code_range_->address()), I would prefer if FreeBlock was a class with a constructor. http://codereview.chromium.org/244022/diff/1001/2004#newcode232 Line 232: // Finally, crash the system. I would remove this line. The call does not always end up crashing the system. :) http://codereview.chromium.org/244022/diff/1001/2004#newcode257 Line 257: FreeBlock free_item = {static_cast<Address>(address), length}; I would prefer that FreeBlock has a constructor. http://codereview.chromium.org/244022/diff/1001/2003 File src/spaces.h (right): http://codereview.chromium.org/244022/diff/1001/2003#newcode323 Line 323: // manages a range of virtual memory. Remove extra space at start of line. http://codereview.chromium.org/244022/diff/1001/2003#newcode336 Line 336: static inline bool contains(void* address); Remove extra space before bool. http://codereview.chromium.org/244022/diff/5002/5007 File test/cctest/test-alloc.cc (right): http://codereview.chromium.org/244022/diff/5002/5007#newcode181 Line 181: void* base = CodeRange::AllocateRawMemory(requested_size, &allocated_size); Line too long? http://codereview.chromium.org/244022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
