Drive by.
http://codereview.chromium.org/244022/diff/5002/5004 File src/heap.cc (right): http://codereview.chromium.org/244022/diff/5002/5004#newcode1929 Line 1929: ASSERT(!CodeRange::exists() || CodeRange::contains(code)); Please do not pass a Code* to a function expecting Address or void*. CodeRange::contains(code->address()). http://codereview.chromium.org/244022/diff/5002/5004#newcode1974 Line 1974: ASSERT(!CodeRange::exists() || CodeRange::contains(code)); Same. http://codereview.chromium.org/244022/diff/5002/5005 File src/spaces.h (right): http://codereview.chromium.org/244022/diff/5002/5005#newcode336 Line 336: static inline bool contains(void* address); Consider making address an Address rather than void* (and casting it at the one place you need to). Get rid of the extra space between inline and bool. http://codereview.chromium.org/244022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
