LGTM. Not too happy with the ever-increasing complexity, but I don't have a
better idea.
To fix --report, you'll have to adapt PrintReport in local/verbose.py,
similar
to the existing line:
if list(o) == [statusfile.PASS]: passes += 1
Suggestion: Introduce a new predicate in statusfile.py:
def IsPass(outcomes):
return ((PASS in outcomes) and (not FAIL in outcomes) and
(not CRASH in outcomes))
Then use that to replace the above line with:
if statusfile.IsPass(o): passes += 1
https://codereview.chromium.org/701933003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
