There are still some obvious problems. I may have time to take a closer look after the weekend if you have something new.
1. Factory::NewConsString doesn't take a pretenure flag, so the code in the patch probably won't compile. Perhaps you forgot to add factory.h and factory.cc to the change list? 2. Your optimization should only be applied to addition, not *any* binary operation with string operands. In JS, "2" / "4" is 0.5, not "24". http://codereview.chromium.org/243051 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
