On 2009/10/03 07:08:26, Kevin Millikin wrote: > There are still some obvious problems. I may have time to take a closer > look > after the weekend if you have something new.
> 1. Factory::NewConsString doesn't take a pretenure flag, so the code in > the > patch probably won't compile. Perhaps you forgot to add factory.h and > factory.cc to the change list? I did, but apparently you gatta edit the file manually when running gcl... now I know :) > 2. Your optimization should only be applied to addition, not *any* binary > operation with string operands. In JS, "2" / "4" is 0.5, not "24". yea, that's a huge error on my part. fixed. ------------ now, like I said in my changelog, it's time for me to get all the tests running smooth. I have compile errors out the wazoo with those cause of strict aliasing and gcc 4.4. I also can't figure out how to run presubmit.py (fails on the popen command to open cpplint.py) and neither can I figure out how to run the linting thing... man... so much stuff... lol. the problem is, this takes so much time to do, when I have like 10 more optimizations that can be written burning through my head... but I gatta wait, I think, until I've got the hang of it with these... --------------- last thing, I noticed when I was running --print_code and stuff today that there were multiple versions of that string in the reloc section. Is that because the garbage collector hasn't cleaned up the second instances, or because I didn't deallocate them properly? thanks man kenny http://codereview.chromium.org/243051 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
