PTAL
(Sorry, I git rebased this accidentally)
https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc#newcode1387
src/arm/full-codegen-arm.cc:1387: if (expr != NULL &&
expr->IsFunctionLiteral() &&
On 2014/11/11 11:50:38, Dmitry Lomov (chromium) wrote:
Style: extract this condition into bool NeedsHomeObject(Expression*
initializer).
Rename expr -> initializer.
Also rename EmitSetHomeObject -> EmitSetHomeObjectIfNeeded.
Same in other ports.
Done.
https://codereview.chromium.org/718473002/diff/80001/src/arm/full-codegen-arm.cc#newcode1756
src/arm/full-codegen-arm.cc:1756: if (value != NULL &&
value->IsFunctionLiteral() &&
On 2014/11/11 11:50:38, Dmitry Lomov (chromium) wrote:
Use NeedsHomeObject (as per previous comment) here
Done.
https://codereview.chromium.org/718473002/diff/80001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/718473002/diff/80001/src/hydrogen.cc#newcode5636
src/hydrogen.cc:5636: if (store_home->HasObservableSideEffects()) {
On 2014/11/11 11:50:38, Dmitry Lomov (chromium) wrote:
Since it is a store, it will always have side effects, so replace this
'if' with
a DCHECK
Done.
https://codereview.chromium.org/718473002/diff/80001/src/runtime/runtime.h
File src/runtime/runtime.h (left):
https://codereview.chromium.org/718473002/diff/80001/src/runtime/runtime.h#oldcode204
src/runtime/runtime.h:204:
On 2014/11/11 11:50:38, Dmitry Lomov (chromium) wrote:
Nit: stray edit
Done.
https://codereview.chromium.org/718473002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
