lgtm if nits are addressed
https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/arm/full-codegen-arm.cc#newcode1756 src/arm/full-codegen-arm.cc:1756: if (value != NULL && value->IsFunctionLiteral() && Use NeedsHomeObject here https://codereview.chromium.org/718473002/diff/100001/src/arm64/full-codegen-arm64.cc File src/arm64/full-codegen-arm64.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/arm64/full-codegen-arm64.cc#newcode1737 src/arm64/full-codegen-arm64.cc:1737: if (value != NULL && value->IsFunctionLiteral() && Use NeedsHomeObject https://codereview.chromium.org/718473002/diff/100001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/hydrogen.cc#newcode5663 src/hydrogen.cc:5663: if (store_home->HasObservableSideEffects()) { 'if' -> DCHECK https://codereview.chromium.org/718473002/diff/100001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/ia32/full-codegen-ia32.cc#newcode1687 src/ia32/full-codegen-ia32.cc:1687: if (value->IsFunctionLiteral() && Use NeedsHomeObject https://codereview.chromium.org/718473002/diff/100001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/718473002/diff/100001/src/x64/full-codegen-x64.cc#newcode1721 src/x64/full-codegen-x64.cc:1721: if (value->IsFunctionLiteral() && Use NeedsHomeObject https://codereview.chromium.org/718473002/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
