Reviewers: Yang,
Message:
PTAL
Description:
Re-enable serialization under harmony-scoping.
[email protected]
BUG=v8:3689
LOG=N
Please review this at https://codereview.chromium.org/717153002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -4 lines):
M src/compiler.cc
M test/mjsunit/regress/regress-2506.js
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
06f3dc19d4ec351c7b5b8de84de9ebe639a022d0..5976cf0794a1a2a308323c715c732c7aec167fe9
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1243,9 +1243,7 @@ Handle<SharedFunctionInfo> Compiler::CompileScript(
result = CompileToplevel(&info);
if (extension == NULL && !result.is_null() && !result->dont_cache()) {
compilation_cache->PutScript(source, context, result);
- // TODO(dslomov): Issue 3628.
- // Reenable when harmony scoping serialization issues are fixed.
- if (FLAG_serialize_toplevel && !FLAG_harmony_scoping &&
+ if (FLAG_serialize_toplevel &&
compile_options == ScriptCompiler::kProduceCodeCache) {
HistogramTimerScope histogram_timer(
isolate->counters()->compile_serialize());
Index: test/mjsunit/regress/regress-2506.js
diff --git a/test/mjsunit/regress/regress-2506.js
b/test/mjsunit/regress/regress-2506.js
index
e6b37d3fdbb1305d81aa6e06c1970322f8745a54..31b57e847fdd8513322a50b9fbc41bdc121d76a7
100644
--- a/test/mjsunit/regress/regress-2506.js
+++ b/test/mjsunit/regress/regress-2506.js
@@ -2,7 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Flags: --harmony-scoping
+// TODO(dslomov): Bug 3689. Code caching does not work well with for-of
+// Flags: --harmony-scoping --cache=none
'use strict';
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
