Please revisit this before landing

https://codereview.chromium.org/718043002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/718043002/diff/20001/src/api.cc#newcode1851
src/api.cc:1851: internal::CpuFeatures::SupportedFeatures();
This is a very bad hash, please use the hashing facilitites from
src/base/functional.h

https://codereview.chromium.org/718043002/diff/20001/src/flags.cc
File src/flags.cc (right):

https://codereview.chromium.org/718043002/diff/20001/src/flags.cc#newcode553
src/flags.cc:553: uint32_t FlagList::Hash() {
Again, src/base/functional.h might help here

https://codereview.chromium.org/718043002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to