lgtm 2
Now it's clear from the function name that this is not to be used as the
cache
tag as is, but that it merely provides the "version" part of it.
I'm not sure what kind of unit test would add value - I'm okay with adding
none.
The test would basically need to be such that it supports making code
changes in
this area.. and I think the most probable code change will be that we
figure out
"oops, XYZ should've also been taken into account in the cache tag", and
there's
no test to tell us that. Tests like "tests that the tag changes if the flag
change" are mildly useful.
https://codereview.chromium.org/718043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
