Reviewers: adamk, Dmitry Lomov (chromium),

Message:
PTAL


https://codereview.chromium.org/722793005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/722793005/diff/1/src/parser.cc#newcode3922
src/parser.cc:3922: ClassLiteral* Parser::ParseClassLiteral(const
AstRawString* name,
I had to split the code from ParserBase into Parser and PreParser
specific implementations :'(

The parser base cannot handle variables and bindings.

On the plus side, it means that the pre parser got simpler.

Description:
Classes: Implement correct name binding

Named class declarations and class expression have a const binding for
the name that is in TDZ for the extends expression.

BUG=v8:3330
LOG=Y
[email protected], adamk

Please review this at https://codereview.chromium.org/722793005/

Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+300, -116 lines):
  M src/ast.h
  M src/ast-numbering.cc
  M src/full-codegen.cc
  M src/parser.h
  M src/parser.cc
  M src/preparser.h
  M src/preparser.cc
  M test/mjsunit/harmony/classes.js


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to