Just a style point, I don't yet feel comfortable enough with the parser to
offer
much insight on this patch.
https://codereview.chromium.org/722793005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/722793005/diff/1/src/parser.cc#newcode3932
src/parser.cc:3932: if (this->IsEvalOrArguments(name)) {
I don't think you need these explicit |this| references now that your
code is in {,pre}parser.cc
Same goes everywhere below where "this->" appears.
https://codereview.chromium.org/722793005/diff/1/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/722793005/diff/1/src/preparser.cc#newcode946
src/preparser.cc:946: return this->EmptyExpression();
"this->" unnecessary here and below, as well.
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
