Thanks. I'll extract the code into a shared function and see if we should
apply
the apply/call logic there.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1658
src/debug.cc:1658: if (!js_function->IsFromNativeScript()) {
On 2014/11/14 19:27:13, aandrey wrote:
BTW, is this in the correct order?
Yeah. This looks wrong.
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js
File test/mjsunit/harmony/debug-step-into-class-extends.js (right):
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js#newcode19
test/mjsunit/harmony/debug-step-into-class-extends.js:19: print(s);
On 2014/11/14 17:19:15, Dmitry Lomov (chromium) wrote:
stray print
I wanted it but I'll remove it.
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js#newcode36
test/mjsunit/harmony/debug-step-into-class-extends.js:36: class Derived
extends GetBase() {} // 0.
On 2014/11/14 19:27:13, aandrey wrote:
should it be "GetBase" instead of "GetBase()" ?
otherwise, looks like we are just calling a function and use it's
return value
as a base class.
It should be GetBase(). We are testing stepping into this function call.
https://codereview.chromium.org/725983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
