PTAL
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1247
src/debug.cc:1247: if (function_proto->shared()->bound()) {
On 2014/11/14 19:27:13, aandrey wrote:
this if-else block is repeated several times below. maybe extract into
a
function?
Done.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1491
src/debug.cc:1491: if (js_function->shared()->bound()) {
On 2014/11/14 19:27:13, aandrey wrote:
repeated again
Done.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1641
src/debug.cc:1641: if (function->shared()->bound()) {
On 2014/11/14 19:27:13, aandrey wrote:
repeated once more.
Done.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1648
src/debug.cc:1648: if (function->shared()->code() ==
On 2014/11/14 19:27:13, aandrey wrote:
maybe the following apply & call checks should be there in the other
places
also?
This is the only place where we have the holder.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1658
src/debug.cc:1658: if (!js_function->IsFromNativeScript()) {
On 2014/11/14 19:36:57, arv wrote:
On 2014/11/14 19:27:13, aandrey wrote:
> BTW, is this in the correct order?
Yeah. This looks wrong.
Done.
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js
File test/mjsunit/harmony/debug-step-into-class-extends.js (right):
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js#newcode19
test/mjsunit/harmony/debug-step-into-class-extends.js:19: print(s);
On 2014/11/14 19:36:58, arv wrote:
On 2014/11/14 17:19:15, Dmitry Lomov (chromium) wrote:
> stray print
I wanted it but I'll remove it.
Done.
https://codereview.chromium.org/725983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
