I think it would make more sense to put this under --harmony-templates
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js
File src/harmony-string.js (right):
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode177
src/harmony-string.js:177: var substitutions =
$Array.prototype.slice.call(arguments, 1);
This is not safe. Use a c-style for loop using %_ArgumentsLength and
%_Arguments instead.
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode187
src/harmony-string.js:187: while (true) {
for (var nextIndex = 0; ; nextIndex++) {
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode188
src/harmony-string.js:188: var next = ToString(raw[nextIndex]);
Don't we know that these are all strings?
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode189
src/harmony-string.js:189: result = result + next;
+=
https://codereview.chromium.org/731573004/diff/20001/test/mjsunit/harmony/string-raw.js
File test/mjsunit/harmony/string-raw.js (right):
https://codereview.chromium.org/731573004/diff/20001/test/mjsunit/harmony/string-raw.js#newcode111
test/mjsunit/harmony/string-raw.js:111: })();
You know I was going to ask for this...
Can you add some tests with accessors so we can ensure the execution
order is correct.
Also, make some of these accessors throw in strange placse.
And also arrays with holes/crap on the prototype.
https://codereview.chromium.org/731573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
