Done and done!
https://codereview.chromium.org/731573004/diff/100001/src/harmony-templates.js
File src/harmony-templates.js (right):
https://codereview.chromium.org/731573004/diff/100001/src/harmony-templates.js#newcode19
src/harmony-templates.js:19: // TODO(*): Use rest parameters when
implemented
On 2014/11/18 19:05:27, arv wrote:
We always use a name here. The name should be of the person to ask
questions to,
not necessarily the person that needs to fix the issue.
Done.
https://codereview.chromium.org/731573004/diff/100001/src/harmony-templates.js#newcode39
src/harmony-templates.js:39: //
-------------------------------------------------------------------
On 2014/11/18 19:05:27, arv wrote:
skip this line
Done.
https://codereview.chromium.org/731573004/diff/100001/test/mjsunit/harmony/string-raw.js
File test/mjsunit/harmony/string-raw.js (right):
https://codereview.chromium.org/731573004/diff/100001/test/mjsunit/harmony/string-raw.js#newcode106
test/mjsunit/harmony/string-raw.js:106: callSiteObj.raw = {length: 2,
'0':"a", '1':"b", '2':"c"};
On 2014/11/18 19:05:27, arv wrote:
don't mix and match ' and ". Stick to one.
Done.
https://codereview.chromium.org/731573004/diff/100001/test/mjsunit/harmony/string-raw.js#newcode106
test/mjsunit/harmony/string-raw.js:106: callSiteObj.raw = {length: 2,
'0':"a", '1':"b", '2':"c"};
On 2014/11/18 19:05:27, arv wrote:
ws after :
Done.
https://codereview.chromium.org/731573004/diff/100001/test/mjsunit/harmony/string-raw.js#newcode250
test/mjsunit/harmony/string-raw.js:250: [1,3,5].forEach(function(v, i) {
On 2014/11/18 19:05:27, arv wrote:
ws after comma
Done.
https://codereview.chromium.org/731573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
